Checklist for ABAP Code Review v2

SAP APPLICATION DEVELOPMENT TEAM Quality Assurance ChecklistSAP Development Objects- Code Review Object ID & Title SAP Developer Database Administrator Code Reviewer Location of Soft Copy Program Objects Objects Names Transaction Code Custom tables (if any) Function group Search Help Object Name Transport Request # Have you read and understood Programming standards documents Not Applicable ABAP Developer Code Reviewer CONTENTS FOR REVIEW Compliance to Development Readiness 1. Versioning/Conflicts - compare development version to production version to ensure no changes are in progress 2. Conflicts - for all changes to substitutions and high traffic user exits review new changes with the on-site coordinator of these areas Compliance to Naming Conventions 3. Adherence to Naming conventions - Object Names (programs, includes, etc) 4. Code Documented 5. Variable Names, Internal Tables & Subroutines 6. Program Structure (order of events in code) 7. Date/Decimal Formats Captured Correctly 8. Multi-Language / Unicode enabling checked Compliance to Technical Specification and Unit Test Plan 9. Program Logic Meets Business Requirements CFI Technical Team: Check List for SAP Development Quality Review Page 1 of 5 Updated: 5/19/2011 © 2005 Warner Bros. Entertainment Inc. All Rights Reserved. CFI Project - Proprietary Confidential Evaluate modification of tables with in loops and execute them once outside the loop if all possible. Unit testing – have extremes been tested – example testing for empty file or data or zero values.Proprietary Confidential . Variants created for Execution (if applicable) 16. 23. Extended Syntax Check using Code Inspector is done 30. Code and Performance Tuning Checklist (refer to ABAP Standards doc) 19. Does every IF or Case ABAP statement has an associated Else covering all possibilities (capture all possible exceptions). Internal table is sorted in correct order which is used in a READ TABLE statement using BINARY SEARCH. Default Values / Search Help for Input Parameters 12. Check for the Wait statements and remove them if all possible. etc. Internal Table usage is efficient 22. Validation Checks Incorporated for Selection screen fields during AT SELECTION SCREEN event 20. CASE statement used in place of IF where field checked for > 2 values 33. 24. Data Declarations are efficient 21. testing full or maximum scenarios. Exit routines properly designed and programmed 26. IS NOT INITIAL is checked for the internal table before making FOR ALL ENTRIES select. 31. Runtime Analysis/SQL Trace is conducted 29. Proper use of SELECT statements & INDEX checked 27. Entertainment Inc. All Rights Reserved. Loops executed without varying clause 34. 36. Selection Screen Layout Meets Requirements 11. Unit Test Plan updated with test cases (both positive and negative test cases) 17.APPLICATION DEVELOPMENT TEAM 10. Return Code(SY-SUBRC) checked after all database table I/O statements 32. 35. Authority Check Incorporated and Authorization Group assigned to program attributes(if applicable) 14. Output Requirements are Met 13. CFI Project . Error Handling and Reporting is adequate 15. Unit Test Plan test cases performed & documented 18. Check for missing or week WHERE clauses in Select statements. Efficient handling Database Updates (COMMITs) 28. CFI Technical Team: Check List for SAP Development Quality Review Page 2 of 5 Updated: 5/19/2011 ___________________________________________________________________________________________________________ © 2005 Warner Bros. Select Appropriate Database Tables for Data Retrieval 25. Check whether or not the table indexed to in favor of the select statements.APPLICATION DEVELOPMENT TEAM 37. Remove unnecessary Select and End select if there are no operations to be executed on the selected data. Message Class is used correctly 50. Check for the key work LIKE and attempt to replace it with a stronger selective condition in loops and select statements. Examine the Append statements within loops statements and utilize the newly recommended SAP append statements. Re-evaluate select statements within loops and determine if there is a better logic that can be used. output etc 58. 45. Transport Tasks Created Correctly 53. 38. analyze them and if it possible undo or redo the logic. selection. 46. TDS updated with the latest changes to the program logic. Entertainment Inc. 40. Object Dependencies Verified for Transport 54. Validate ZOVITAL for Object id Information exists across the environments (DEV/QA/Production systems) 57. Incomplete Case statements (include in Case others where missing). 43. Application server file structures are in place 59. 44. 39. Program Attributes are filled in correctly 48. Program Documentation incorporated 61. CFI Project . Cutover Checklist updated accordingly 55.Proprietary Confidential . Custom Tables Created/Grouped Correctly 52. Success/Failure alerts for Applications incorporated 60. Function Groups Created/Assigned Correctly 51. Check and replace the Select (*) with Select (parameters / fields). Identify Submit statements in loops or Select statements. End to End monitoring (Interfaces or any RICEF object that moves data from one system to another) Example: the use of ZIDOCDASH or ZOREPORT Administrative checklist 47. Check for and replace if possible Nested loop statements. No hard coded values used in the program * CFI Technical Team: Check List for SAP Development Quality Review Page 3 of 5 Updated: 5/19/2011 ___________________________________________________________________________________________________________ © 2005 Warner Bros. 42. 41. RICEFW Vital Information updated in FDS/TDS/UTD/Programs 56. All Rights Reserved. Development Package is assigned correctly 49. Was there a need to modify and code in a user exit that was already used by other team? If yes. Versioning . please notify onsite Development team lead 64. When New font family is added for SAPScripts or SMARTForms. All debugging code is removed from the program Production Readiness 68. Text Elements and message id used (no hardcoded text strings). have you compared the main program version? 67. CFI Project . 63. make sure you have a task in cookbook to validate future code/logic in PRD for future enhancements 70.compare version between QA and Production systems to ensure correct changes are moving to Production system (Include screenshot of the conflict analysis) 69. Is it a new include or function module? If yes.Proprietary Confidential . Entertainment Inc. verify that the Parent is regenerated and included in the transport 66. Does this object append fields to standard SAP tables? If yes. please notify Development team lead 65. Is the code in an Include or not the main program? If yes. When object is shared between different release. make sure device types associated with font family is activated in QA and PROD systems Comments: DATABASE ADMINISTRATOR DEVELOPER (Required) CODE REVIEWER (Required) CFI Technical Team: Check List for SAP Development Quality Review Page 4 of 5 Updated: 5/19/2011 ___________________________________________________________________________________________________________ © 2005 Warner Bros. All Rights Reserved.APPLICATION DEVELOPMENT TEAM 62. CFI Technical Team: Check List for SAP Development Quality Review Page 5 of 5 Updated: 5/19/2011 ___________________________________________________________________________________________________________ © 2005 Warner Bros. Entertainment Inc. If it is not practical to put these values in a z table. condition table or ZPARAMS make sure that the customer signs off on the hard coding. document types etc. Code Reviewer Name Signature Date • Hard Coding refers particularly to hard coding Master Data values like company code. CFI Project .APPLICATION DEVELOPMENT TEAM SIGN-OFF Database Admin. All Rights Reserved.Proprietary Confidential . File signoff with Code Review.